Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task-27] Set up API call to fetch users Part 2 #51

Merged
merged 4 commits into from
Aug 9, 2023
Merged

Conversation

cinderlee
Copy link
Contributor

[Task-27] Set up API call to fetch users

This PR handles setting up an api file where we can store methods to hit the endpoints in tally-backend. Currently only GET users endpoint is added.

How Has This Been Tested?

Tested with the backend changes made in this PR: tally-team/tally-backend#65 + made a call to get the users endpoint somewhere in App (removed the code since it was for testing purposes)

Screen Shot 2023-08-08 at 10 06 39 AM

@cinderlee cinderlee changed the title [Task-27] Set up API call to fetch users [Task-27] Set up API call to fetch users Part 2 Aug 8, 2023
@@ -14,6 +14,7 @@
"dependencies": {
"@babel/preset-typescript": "^7.16.7",
"@expo/webpack-config": "^18.0.1",
"axios": "^1.4.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk if there's a preference of how to make the API call? or if y'all preference a different library - open to testing!

@michello
Copy link
Member

michello commented Aug 8, 2023

Does this throw an error if we don't have server running? If so, can we add documentation to ensure it's running? c:
I also wonder whether we should have a general tally-doc repo, that's for documentation purposes. Because stuff like running app will require set up from both sides once the FE and BE are connected. 🤔

@cinderlee
Copy link
Contributor Author

Does this throw an error if we don't have server running? If so, can we add documentation to ensure it's running? c: I also wonder whether we should have a general tally-doc repo, that's for documentation purposes. Because stuff like running app will require set up from both sides once the FE and BE are connected. 🤔

@michello currently no since the endpoint isn't called anywhere atm, but later on when we do integrate the APIs we will need both sides running (updated readme with small section on that)

@cinderlee cinderlee merged commit 8cf3931 into main Aug 9, 2023
1 check passed
@cinderlee cinderlee deleted the clee/setup-api branch August 9, 2023 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants